Skip to content

Svg improvements, also more verbose images-test page #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 19, 2025
Merged

Svg improvements, also more verbose images-test page #133

merged 15 commits into from
Jun 19, 2025

Conversation

jensens
Copy link
Member

@jensens jensens commented Sep 8, 2022 •
edited
Loading

need merged and tested with/after merge of plone/plone.scale#68

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens jensens mentioned this pull request Sep 8, 2022
Merged
@mauritsvanrees mauritsvanrees mentioned this pull request Sep 29, 2022
Open
@jensens
Copy link
Member Author

jensens commented Apr 4, 2025

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

I have released plone.scale 4.2.0 which has the method that you added there. I have updated 6.0/1/2-dev on dist.plone.org.

Meanwhile Jenkins tests fail with:

Unicode strings with encoding declaration are not supported. Please use bytes input or XML fragments without declaration.

@jensens jensens force-pushed the svg-improvements branch from 68bf74b to f964aea Compare April 7, 2025 11:30
@jensens
Copy link
Member Author

jensens commented Apr 7, 2025

@jenkins-plone-org please run jobs

@jensens jensens marked this pull request as ready for review April 7, 2025 11:36
@jensens jensens requested a review from mauritsvanrees April 7, 2025 11:36
@jensens
Copy link
Member Author

jensens commented Apr 7, 2025

@mauritsvanrees all green now

davisagli
davisagli reviewed May 21, 2025
View reviewed changes
mauritsvanrees added a commit that referenced this pull request Jun 19, 2025
@mauritsvanrees
Require plone.scale 4.2.0 as minimum.
52af470 
Since our last release, we use a function introduced in that version.
See #133 (comment)
@mauritsvanrees mauritsvanrees mentioned this pull request Jun 19, 2025
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Jun 19, 2025
@mauritsvanrees
[fc] Repository: plone.namedfile
0979eee 
Branch: refs/heads/main
Date: 2025-06-19T12:03:28+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@52af470

Require plone.scale 4.2.0 as minimum.

Since our last release, we use a function introduced in that version.
See plone/plone.namedfile#133 (comment)

Files changed:
A news/+scale.internal
M setup.py
Repository: plone.namedfile

Branch: refs/heads/main
Date: 2025-06-19T12:06:16+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be>
Commit: plone/plone.namedfile@e3b2d58

Merge pull request #183 from plone/maurits-plone-scale-420

Require plone.scale 4.2.0 as minimum.

Files changed:
A news/+scale.internal
M setup.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Jun 19, 2025
@mauritsvanrees
[fc] Repository: plone.namedfile
38f42cd 
Branch: refs/heads/main
Date: 2025-06-19T12:03:28+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@52af470

Require plone.scale 4.2.0 as minimum.

Since our last release, we use a function introduced in that version.
See plone/plone.namedfile#133 (comment)

Files changed:
A news/+scale.internal
M setup.py
Repository: plone.namedfile

Branch: refs/heads/main
Date: 2025-06-19T12:06:16+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be>
Commit: plone/plone.namedfile@e3b2d58

Merge pull request #183 from plone/maurits-plone-scale-420

Require plone.scale 4.2.0 as minimum.

Files changed:
A news/+scale.internal
M setup.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Jun 19, 2025
@mauritsvanrees
[fc] Repository: plone.namedfile
897a1fe 
Branch: refs/heads/main
Date: 2025-06-19T12:03:28+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@52af470

Require plone.scale 4.2.0 as minimum.

Since our last release, we use a function introduced in that version.
See plone/plone.namedfile#133 (comment)

Files changed:
A news/+scale.internal
M setup.py
Repository: plone.namedfile

Branch: refs/heads/main
Date: 2025-06-19T12:06:16+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be>
Commit: plone/plone.namedfile@e3b2d58

Merge pull request #183 from plone/maurits-plone-scale-420

Require plone.scale 4.2.0 as minimum.

Files changed:
A news/+scale.internal
M setup.py
@mauritsvanrees
Undo the changes to test.pt.
3dd427d 
They are partially wrong, reintroducing the deprecated 'direction' instead of 'mode'.
I want to merge the SVG improvements, as I already accidentally made a related change on the main branch.
@mauritsvanrees
Copy link
Member

Sorry @jensens, in commit 3dd427d I have undone your changes to the images-test page. They are partially wrong, reintroducing the deprecated 'direction' instead of 'mode'. I should have seen that earlier. There are good parts too, I would like to have those in, but please create a new PR for that.

I will merge this one now, to go into Plone 6.1.2.

@mauritsvanrees mauritsvanrees merged commit 0df02cf into main Jun 19, 2025
13 of 19 checks passed
@mauritsvanrees mauritsvanrees deleted the svg-improvements branch June 19, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli left review comments

@mauritsvanrees mauritsvanrees Awaiting requested review from mauritsvanrees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jensens @mister-roboto @mauritsvanrees @davisagli @rohnsha0